Avoid SQLite startup races during parallel Bun qmd initialization#442
Open
Avoid SQLite startup races during parallel Bun qmd initialization#442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Parallel
qmdprocesses can fail during startup with transient SQLite lock errors such asdatabase is lockedandSQLITE_BUSY_RECOVERY.Root cause
busy_timeoutwas applied after early startup worksqlite-vecprobe could run before contention handling was configuredFix
sqlite-vecprobe workPRAGMA journal_mode = WALwhen the database is already in WAL modeTesting
bun test --timeout 60000 --preload ./src/test-preload.ts test/cli.test.tsbunx vitest run --reporter=verbose test/store.helpers.unit.test.ts test/store.test.ts test/cli.test.tsbun src/cli/qmd.ts vsearch testruns exit 0 with no lock-related stderrvsearchrepro exits 0 with no lock-related stderr