Enable updating an item’s accessible attribute#6
Open
ejensen wants to merge 1 commit intotoddkramer:masterfrom
Open
Enable updating an item’s accessible attribute#6ejensen wants to merge 1 commit intotoddkramer:masterfrom
ejensen wants to merge 1 commit intotoddkramer:masterfrom
Conversation
Previously the query to fetch the existing item was requiring that the existing item’s accessibility attribute was the same as the new accessibility attribute. This would return no results, which caused the new item code path to be executed and failed since there is an existing item, just with a different accessibility attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the query to fetch the existing item was requiring that the existing item’s accessibility attribute was the same as the new accessibility attribute. This would return no results, which caused the
existingData == nilcode path to be executed and failed since there is an existing item, just with a different accessibility attribute