Skip to content

chore: bump up manticoresearch/manticore to v10 #12935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 26, 2025

#12816

PR Dependency Tree

This tree was auto-generated by Charcoal

Summary by CodeRabbit

  • Chores
    • Updated the default Manticore Search version in development environment configurations from 9.3.2 to 10.1.0.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Manticore Search version used in the Docker configurations from v9.3.2 to v10.1.0.

  • Updated the Manticore Search image version in .docker/dev/compose.yml.example
  • Updated .docker/dev/.env.example to reflect the new version
  • Updated the Manticore Search image version in the .devcontainer/docker-compose.yml

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.docker/dev/compose.yml.example Updated the default Manticore Search version
.docker/dev/.env.example Bumped the MANTICORE_VERSION to 10.1.0
.devcontainer/docker-compose.yml Updated the Manticore Search image version

@fengmk2 fengmk2 requested review from forehalo, darkskygit and a team June 26, 2025 05:45
@fengmk2 fengmk2 enabled auto-merge June 26, 2025 05:45
Copy link
Contributor

coderabbitai bot commented Jun 26, 2025

Walkthrough

The Manticore Search Docker image version was updated from 9.3.2 to 10.1.0 across multiple configuration files, including Docker Compose and environment example files. No other service configurations, environment variables, or exported entities were modified.

Changes

File(s) Change Summary
.devcontainer/docker-compose.yml Updated Manticore Search image version from 9.3.2 to 10.1.0
.docker/dev/.env.example, .docker/dev/compose.yml.example Updated default Manticore Search version to 10.1.0

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant DockerCompose
    participant ManticoreSearch

    Developer->>DockerCompose: Start services (with updated config)
    DockerCompose->>ManticoreSearch: Pull image:10.1.0
    ManticoreSearch-->>DockerCompose: Service ready (v10.1.0)
    DockerCompose-->>Developer: All services running
Loading

Possibly related PRs

Suggested labels

app:server

Suggested reviewers

  • forehalo

Poem

A hop and a skip, a version anew,
Manticore leaps from old to true.
Compose and configs, all in a row,
Now pull ten-point-one, let the queries flow!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 320d2f5 and 4b55318.

📒 Files selected for processing (3)
  • .devcontainer/docker-compose.yml (1 hunks)
  • .docker/dev/.env.example (1 hunks)
  • .docker/dev/compose.yml.example (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (78)
  • GitHub Check: Frontend Copilot E2E Test (8, 8)
  • GitHub Check: Frontend Copilot E2E Test (3, 8)
  • GitHub Check: Frontend Copilot E2E Test (4, 8)
  • GitHub Check: Frontend Copilot E2E Test (6, 8)
  • GitHub Check: Frontend Copilot E2E Test (5, 8)
  • GitHub Check: Frontend Copilot E2E Test (7, 8)
  • GitHub Check: Cloud E2E Test 5/6
  • GitHub Check: Frontend Copilot E2E Test (1, 8)
  • GitHub Check: Cloud E2E Test 6/6
  • GitHub Check: Frontend Copilot E2E Test (2, 8)
  • GitHub Check: Cloud E2E Test 3/6
  • GitHub Check: Cloud E2E Test 4/6
  • GitHub Check: Cloud Desktop E2E Test
  • GitHub Check: Cloud E2E Test 1/6
  • GitHub Check: Server Copilot Api Test
  • GitHub Check: Cloud E2E Test 2/6
  • GitHub Check: Server Test with Elasticsearch
  • GitHub Check: Server E2E Test
  • GitHub Check: Server Test (6, 8)
  • GitHub Check: Server Test (7, 8)
  • GitHub Check: Server Test (5, 8)
  • GitHub Check: Server Test (2, 8)
  • GitHub Check: Server Test (0, 8)
  • GitHub Check: Server Test (4, 8)
  • GitHub Check: Server Test (3, 8)
  • GitHub Check: Server Test (1, 8)
  • GitHub Check: Check Git Status
  • GitHub Check: Unit Test (5)
  • GitHub Check: Unit Test (3)
  • GitHub Check: Unit Test (1)
  • GitHub Check: Unit Test (4)
  • GitHub Check: Unit Test (2)
  • GitHub Check: Native Unit Test
  • GitHub Check: E2E Test (9)
  • GitHub Check: E2E Test (10)
  • GitHub Check: E2E Test (5)
  • GitHub Check: E2E Test (7)
  • GitHub Check: E2E BlockSuite Cross Browser Test (1, chromium)
  • GitHub Check: E2E Test (8)
  • GitHub Check: E2E Test (4)
  • GitHub Check: E2E Test (2)
  • GitHub Check: E2E Mobile Test (4)
  • GitHub Check: E2E Test (6)
  • GitHub Check: E2E Test (3)
  • GitHub Check: E2E Test (1)
  • GitHub Check: Build @affine/electron renderer
  • GitHub Check: Build AFFiNE native (x86_64-pc-windows-msvc)
  • GitHub Check: y-octo binding test on aarch64-pc-windows-msvc
  • GitHub Check: y-octo binding test on x86_64-pc-windows-msvc
  • GitHub Check: fuzzing
  • GitHub Check: y-octo binding test on x86_64-apple-darwin
  • GitHub Check: E2E BlockSuite Cross Browser Test (2, firefox)
  • GitHub Check: E2E BlockSuite Cross Browser Test (2, webkit)
  • GitHub Check: Build AFFiNE native (aarch64-pc-windows-msvc)
  • GitHub Check: Run native tests
  • GitHub Check: E2E BlockSuite Test (7)
  • GitHub Check: E2E BlockSuite Test (5)
  • GitHub Check: E2E BlockSuite Cross Browser Test (2, chromium)
  • GitHub Check: E2E Mobile Test (5)
  • GitHub Check: E2E BlockSuite Cross Browser Test (1, webkit)
  • GitHub Check: E2E BlockSuite Cross Browser Test (1, firefox)
  • GitHub Check: E2E Mobile Test (2)
  • GitHub Check: E2E BlockSuite Test (9)
  • GitHub Check: E2E BlockSuite Test (8)
  • GitHub Check: E2E Mobile Test (3)
  • GitHub Check: E2E BlockSuite Test (10)
  • GitHub Check: E2E Mobile Test (1)
  • GitHub Check: E2E BlockSuite Test (2)
  • GitHub Check: E2E BlockSuite Test (3)
  • GitHub Check: E2E BlockSuite Test (1)
  • GitHub Check: E2E BlockSuite Test (6)
  • GitHub Check: E2E BlockSuite Test (4)
  • GitHub Check: Analyze (typescript, blocksuite)
  • GitHub Check: Analyze (javascript, blocksuite)
  • GitHub Check: Analyze (typescript, affine)
  • GitHub Check: Analyze (javascript, affine)
  • GitHub Check: Lint
  • GitHub Check: Typecheck
🔇 Additional comments (6)
.docker/dev/.env.example (2)

15-15: Version string correctly updated
The variable now points to 10.1.0; this keeps the env file consistent with the compose files.


14-16: Double-check breaking-change impact of the v10 major bump
Jumping from 9.x → 10.x can introduce index-format or API changes (see Manticore Search release notes). Before merging, please confirm:

  1. Existing dev data directories do not need a rebuild.
  2. Any client libraries/images in the repo are still compatible with 10.1.0.
  3. Local onboarding docs mention the new default.
.docker/dev/compose.yml.example (2)

29-30: Compose image tag updated – looks good
The service correctly defaults to ${MANTICORE_VERSION:-10.1.0} matching the env file.


27-31: Validate schema & volume compatibility after upgrade
Persistent volume manticoresearch_data may already contain 9.x indexes. If so, the container could fail to start or silently corrupt data. Consider:

# Option: force a clean volume on first run
#   volumes:
#     - manticoresearch_data:/var/lib/manticore      # current
#  ▼ add a comment for devs
#     # ⚠️ Delete the volume if upgrading from 9.x → 10.x: docker volume rm affine_manticoresearch_data

At minimum, add a note to the README / dev-env docs.

.devcontainer/docker-compose.yml (2)

28-29: Consistent bump inside devcontainer – approved
The dev-container will now spin up 10.1.0 by default, staying in sync with other configs.


27-39: Confirm indexer health & liveness probes
If the IDE/dev-container relies on startup timing (e.g., waits for port 9308) you may need to update any health-check scripts; Manticore 10 changes startup logs and readiness.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.22%. Comparing base (320d2f5) to head (4b55318).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #12935      +/-   ##
==========================================
- Coverage   56.22%   56.22%   -0.01%     
==========================================
  Files        2667     2667              
  Lines      127717   127717              
  Branches    20128    20128              
==========================================
- Hits        71810    71805       -5     
- Misses      54277    54280       +3     
- Partials     1630     1632       +2     
Flag Coverage Δ
server-test 78.99% <ø> (ø)
unittest 31.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant