Conversation
- Replace setup.py and MANIFEST.in with modern pyproject.toml - Add uv for fast dependency management and lockfile support - Use hatch with hatch-vcs for building and automatic versioning - Update GitHub workflows to use uv and latest actions - Add matrix testing across Python 3.10-3.13 - Maintain all existing dependencies and optional groups - Enable reproducible builds with uv.lock Co-authored-by: openhands <openhands@all-hands.dev>
- Apply black formatting to 4 files - Standardize quote usage and line formatting - Ensure code style consistency Co-authored-by: openhands <openhands@all-hands.dev>
- Move version file to servey/_version.py (inside package) - Add black exclude pattern for _version.py files - Add _version.py to .gitignore as it's generated by hatch-vcs - Resolves CI black formatting failures Co-authored-by: openhands <openhands@all-hands.dev>
- Add E0401 (import-error) to .pylintrc disable list for optional dependencies - Fix R0917 (too-many-positional-arguments) in action.py - Fix E1123 (unexpected-keyword-arg) in dataclass_factory.py - Fix W0613 (unused-argument) in websocket_event_channel_endpoint.py - All pylint checks now pass with perfect score
- Renamed 'debug' field to 'server_debug' for better clarity - Updated all references to use the new field name - Improves code readability and avoids potential naming conflicts Co-authored-by: openhands <openhands@all-hands.dev>
- Changed GraphQL constructor parameter from 'debug' to 'graphiql' - Corrects parameter name to match Strawberry GraphQL library API - Ensures proper GraphiQL interface configuration Co-authored-by: openhands <openhands@all-hands.dev>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
- Updated imports from deprecated strawberry.field to strawberry.types.field - Updated imports from strawberry.type to strawberry.types.base - Fixed GraphQL parameter from 'graphiql' to 'graphql_ide' (deprecated) - Resolved ModuleNotFoundError for StrawberryField and UNRESOLVED - All 198 tests now passing with modern Strawberry GraphQL library Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Migration: setuptools → uv + hatch
This PR modernizes the project's build system and dependency management by migrating from setuptools to uv with hatch, following the same configuration style as the injecty repository.
📦 Changes Made
New Files:
pyproject.toml- Modern Python project configuration with:uv.lock- Lockfile for reproducible dependency resolution_version.py- Generated version file from hatch-vcsUpdated Files:
.github/workflows/quality.yml- Modernized CI workflow:uv sync)uv runfor executing tools.github/workflows/release.yml- Streamlined release process:UV_PUBLISH_TOKENRemoved Files:
setup.py- Replaced by pyproject.tomlMANIFEST.in- Replaced by hatch build configuration✨ Benefits
🧪 Tested & Verified
uv sync --extra devuv builduv run pytest,uv run black .,uv run pylint🔄 Migration Notes
📋 Usage After Merge
This migration brings the servey project in line with modern Python development practices while maintaining full backward compatibility.
@tofarr can click here to continue refining the PR