Move distribution-based logic to config.py#151
Open
266-750Balloons wants to merge 1 commit intotom-james-watson:masterfrom
Open
Move distribution-based logic to config.py#151266-750Balloons wants to merge 1 commit intotom-james-watson:masterfrom
266-750Balloons wants to merge 1 commit intotom-james-watson:masterfrom
Conversation
Author
|
And I also fixed #21, at least for me, based on the suggestion in 21#issuecomment-736195616. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #147, this moves anything that changes based on the distribution format of the picker to config.py to make it easier for porting to other distributions and increase maintainability. I have tested the commits in all 3 distribution formats, and there is no change to functionality.
Once again, thank you for your hard work on this project. It really feels like the least terrible emoji picker on Linux.