Conversation
|
Hi - thanks for this! What OSes/versions have you tried this build on? Any issues? |
| ```bash | ||
| sudo apt install xdotool libgtk-3-dev libgirepository1.0-dev python3-venv gir1.2-keybinder-3.0 libkeybinder-dev desktop-file-utils | ||
| # Debian/Ubuntu | ||
| sudo apt install xdotool libgtk-3-dev libgirepository1.0-dev python3-venv gir1.2-keybinder-3.0 libkeybinder-dev desktop-file-utils pipenv flatpak-builder libcairo2-dev libxt-dev |
There was a problem hiding this comment.
Added pipenv flatpak-builder libcairo2-dev libxt-dev
| If so, run the following command: | ||
|
|
||
| ```bash | ||
| sudo pip3 install pipenv |
| @@ -1,5 +1,5 @@ | |||
| project('emote', | |||
| version: '4.0.2', | |||
| version: '4.1.0', | |||
There was a problem hiding this comment.
This must have updated auto-magically with the build steps I followed
|
|
||
| [requires] | ||
| python_version = "3.11" | ||
| python_version = "3.12" |
There was a problem hiding this comment.
Feel free to revert this, and the Pipfile.lock - I just used the version of Python I had installed locally
|
Ready for review @tom-james-watson |
|
@tom-james-watson when you have a moment to review, just let me know what I have to revert/fix/change, and I'll sort it out for you. I've been using the local build version for 3 days without issues |
|
@tom-james-watson Another user here! I really encourage this PR to be merged. The flatpak version keeps telling us to update, and it's getting a bit annoying atp. (By the way, thank you for the PR, @rj-xy!! ❤️ ) |
|
This was fixed by a flathub maintainer directly: flathub/com.tomjwatson.Emote#6. He then made a PR with the relevant changes back to this repo. Do you mind updating this PR to include the changes he's making on that PR? For example his PR is failing to build the flatpak via the GitHub action, I think because it's missing changes you have here. When you update the PR, I can kick off the GitHub action to ensure everything is working! Sorry for the delay on this - life has got in the way, plus I'm not on Linux that much these days. |
|
@tom-james-watson can you close this PR and use #158 instead please. If you think it's still worth including the other changes I made in this PR, let me know and I'll grab the changes from #158 and update everything I can (this PR dates back to June 2024) Lol, I'm still on that DEV build 😅 |
4 participants
Tested on Kubuntu 24.04