fix: capitalize headers #443
Open
+143
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
But i broke most of the tests, need help |
tomas
reviewed
Jul 31, 2025
| // now that all our headers are set, overwrite them if instructed. | ||
| for (var h in options.headers) | ||
| config.headers[h.toLowerCase()] = options.headers[h]; | ||
| config.headers[h] = options.headers[h]; |
Owner
There was a problem hiding this comment.
This is a key part. We need to ensure that h is in PascalCase format, otherwise a user might pass a header in lowercase format which might not overwrite a previously set one.
Author
There was a problem hiding this comment.
Yes, makes sense, i will add a formatting util function, probably take one from axios and add it here
But what do we do with tests? Why changing headers broke all the tests? I didnt dive much into this problems so i'm unsure
Owner
There was a problem hiding this comment.
A quick look suggests that the changes broke a lookup either in the tests or in the code itself:
I'm happy to merge your PR but we need to make sure we don't break anything!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just have basically changed all headers manually everywhere in code to match the rfc4229.