Merged
Conversation
- Move smartcard from dependencies to devDependencies (only used for demo) - Update package description to reflect library is transport-agnostic - Rewrite README to clarify library works with any transport - Add examples for custom transport and direct APDU building - Remove hardware-specific sections from README - Update Card interface comment Fixes #32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The core library doesn't require
smartcard- it works with any transport that can send/receive byte arrays. Move it to devDependencies since it's only used for the demo.Changes
smartcardfrom dependencies to devDependenciesTest plan
Fixes #32