fix(parser): Fix stack overflow in value() on repeated '='#1131
Open
dimbleby wants to merge 1 commit intotoml-rs:mainfrom
Open
fix(parser): Fix stack overflow in value() on repeated '='#1131dimbleby wants to merge 1 commit intotoml-rs:mainfrom
dimbleby wants to merge 1 commit intotoml-rs:mainfrom
Conversation
dimbleby
force-pushed
the
another-recursion-fix
branch
from
5d7139e to
fa8928b
Compare
epage
reviewed
Mar 30, 2026
epage
reviewed
Mar 30, 2026
Rewrite the extra '=' handling in value() to iteratively skip redundant '=' tokens in a loop instead of recursing, preventing stack overflow on long runs of '=' characters. Add regression test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dimbleby
force-pushed
the
another-recursion-fix
branch
from
fa8928b to
a77c61e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1129 and #1130
Rewrite the extra '=' handling in value() to iteratively skip redundant '=' tokens in a loop instead of recursing, preventing stack overflow on long runs of '=' characters. Add regression test.