Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dimbleby
force-pushed
the
micro-optimisations
branch
2 times, most recently
from
eb37e26 to
1be22da
Compare
epage
reviewed
Mar 30, 2026
epage
reviewed
Mar 30, 2026
crates/toml_edit/src/inline_table.rs
Outdated
| pub(crate) fn append_values<'s>( | ||
| &'s self, | ||
| parent: &[&'s Key], | ||
| parent: &mut Vec<&'s Key>, |
Member
There was a problem hiding this comment.
If we do this, it is unusual enough that this will need documentation
Use push/pop on a shared Vec instead of cloning the parent path for every child in append_values() and append_all_values(). Paths are now only cloned when storing leaf values in the result. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
values.values is already a Vec<Item>, so into_iter().collect::<Vec<_>>() just copies it needlessly. Use the owned Vec directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dimbleby
force-pushed
the
micro-optimisations
branch
from
1be22da to
4de79db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of small optimisations:
get_values()Vecinto anotherThe second seems easy, the first is maybe a little bit on the clever side for modest gain.
If you want both, or neither, thats easy: merge or reject. If you want one but not the other let me know.