Beam hardening test corrections and small config.py bug fix#64
Open
aps-7bm wants to merge 28 commits intotomography:mainfrom
Open
Beam hardening test corrections and small config.py bug fix#64aps-7bm wants to merge 28 commits intotomography:mainfrom
aps-7bm wants to merge 28 commits intotomography:mainfrom
Conversation
Lots of bug fixes so allow reconstruction to run.
Merging in all upstream changes up to 2/15/2023
This should also allow it to work even if beam hardening is not used.
1. Problems with import of logging. 2. Get reconstruction with different flatfield and projection exposures to work. This should now work even if beam hardening is not needed.
…nto aps-7bm-beamhardening with adjustmnets
Sync with upstream
Aps 7bm beamhardening
Use pathlib.Path object to cycle through the TIFF recon files. Old code hard-coded there to be 24 files when there were only 22 from the test dataset. More explicitly tests for the presence of an HDF recon file. Removed the try - except blocks, which just acted to skip over any exceptions. It seems better in test code to allow such exceptions to be raised so errors aren't masked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor changes to the beam hardening tests and a small bug fix in config.py to account for the deprecation of numpy.string_.