Reorder move_sample_out to move Y before X#176
Open
decarlof wants to merge 1 commit intotomography:masterfrom
Open
Reorder move_sample_out to move Y before X#176decarlof wants to merge 1 commit intotomography:masterfrom
decarlof wants to merge 1 commit intotomography:masterfrom
Conversation
…id mechanical interference (e.g., furnace clearance).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust move_sample_out() motion order so the sample moves Y first, then X when moving out of beam. This prevents mechanical interference in setups where vertical clearance is required before lateral translation (e.g., furnace installed above the sample).
Touches tomoscan.py so feel free to close without merging if it affects your setup (we can move this into our derived classes).