Open
Conversation
h-oikawa-jp
reviewed
Feb 27, 2024
h-oikawa-jp
left a comment
h-oikawa-jp
left a comment
There was a problem hiding this comment.
NextbeatのAngularプロダクトではRxjsやNGXSがよく使われています。
余裕があればこれらのライブラリを用いてStoreなどの状態管理を実装してみて下さい。
| }) | ||
| export class TodoCategoryService { | ||
| public async getAll(): Promise<TodoCategory[]> { | ||
| const response = await fetch('http://localhost:9000/todo-category/list', { |
There was a problem hiding this comment.
http://localhost:9000/
実際のプロダクトではAPIサーバのドメインはproductionやstagingなど環境ごとに変わる場合が殆どです。
こういった値はconfigや環境変数で一律切り替えられるようコーディングして下さい。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API 呼び出し以外の部分の必須要件の機能を実装しました。見た目の調整はまだです。
追記：API呼び出し部分も実装しました。