Skip to content

feat: improve global loading animation timing #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chmurson merged 1 commit into from
Dec 3, 2025
Merged

feat: improve global loading animation timing #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fe/src/components/RootRoutes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,15 @@ const router = createBrowserRouter([
{
path: "/unlock-box/:roomToken?",
element: (
<Suspense fallback={<FullPageLoader />}>
<Suspense fallback={<FullPageLoader message="Loading..." />}>
<LockedBoxes />
</Suspense>
),
},
{
path: "/lock-box/:roomToken?",
element: (
<Suspense fallback={<FullPageLoader />}>
<Suspense fallback={<FullPageLoader message="Loading..." />}>
<CreationBoxes />
</Suspense>
),
Expand Down
4 changes: 3 additions & 1 deletion fe/src/components/ui/FullPageLoader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { Loader } from "./Loader";

let timeoutHandler: NodeJS.Timeout | undefined;

const RESET_GLOBAL_LOADING_ANIMATION_TIMEOUT_IN_MS = 250;

export const FullPageLoader: FC<{ message?: string }> = ({
message = "Loading Stashcrate...",
}) => {
Expand All @@ -17,7 +19,7 @@ export const FullPageLoader: FC<{ message?: string }> = ({
?.querySelector("#root")
?.setAttribute("data-loading-start-timestamp", "");
console.log("Timeout cleared");
}, 5000);
}, RESET_GLOBAL_LOADING_ANIMATION_TIMEOUT_IN_MS);
};
}, []);

Expand Down