Skip to content

fix: some improvements to handling cases when keyholders gets disconn… #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chmurson merged 1 commit into from
Dec 3, 2025
Merged

fix: some improvements to handling cases when keyholders gets disconn… #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions fe/src/components/Box/sub-pages/RestoreBoxes/OpenLockedBox/hooks/useInitiateCounter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ export function useInitiateCounter({
);
}, [sharesRequiredToStartCounter, shareAccessKeyMapByKeyHolderId]);

console.log("------");
console.log("isTresholdReached", isTresholdReached);
console.log("sharesRequiredToStartCounter", sharesRequiredToStartCounter);
console.log("shareAccessKeyMapByKeyHolderId", shareAccessKeyMapByKeyHolderId);

const prevIsTresholdReached = usePrevious(isTresholdReached);

useEffect(() => {
Expand Down
8 changes: 8 additions & 0 deletions fe/src/stores/boxStore/joinLockedBoxStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,14 @@ export const useJoinLockedBoxStore = create<JoinLockedBoxState>()(
),
);

const shareAccessKeyByKeyHolderId = {
...state.shareAccessKeyByKeyHolderId,
};

for (const newOfflineKeyholders of newOffLineKeyHolders) {
delete shareAccessKeyByKeyHolderId[newOfflineKeyholders.id];
}

filteredPayload.onlineKeyHolders = newOnlineKeyHolders;
filteredPayload.offLineKeyHolders = newOffLineKeyHolders;
}
Expand Down
30 changes: 22 additions & 8 deletions fe/src/stores/boxStore/openLockedBoxStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,22 +180,36 @@ export const useOpenLockedBoxStore = create<OpenLockedBoxState>()(

const onlineKeyHoldersCount = newOnlineKeyHolders.length;

const shareAccessKeyByKeyHolderId = {
...state.shareAccessKeyByKeyHolderId,
};

const shareAccessKeyMapByKeyHolderId = {
...Object.fromEntries(
Object.entries(state.shareAccessKeyMapByKeyHolderId).map(
([keyHolderId, shareAccesKeyMap]) => {
delete shareAccesKeyMap[disconnectedKeyHolderId];
return [keyHolderId, shareAccesKeyMap];
},
),
),
};

delete shareAccessKeyByKeyHolderId[disconnectedKeyHolderId];
delete shareAccessKeyMapByKeyHolderId[disconnectedKeyHolderId];

const newState = {
shareAccessKeyByKeyHolderId: {
...state.shareAccessKeyByKeyHolderId,
[disconnectedKeyHolderId]: false,
},
shareAccessKeyMapByKeyHolderId: {
...state.shareAccessKeyMapByKeyHolderId,
[disconnectedKeyHolderId]: {},
},
shareAccessKeyByKeyHolderId,
shareAccessKeyMapByKeyHolderId,
onlineKeyHolders: newOnlineKeyHolders,
offLineKeyHolders: [
disconnectedKeyHolder,
...state.offLineKeyHolders,
],
};

console.log(newState);

if (
onlineKeyHoldersCount === 0 &&
state.getTopLobbyMetaStatus() !== "keyholder-able-to-unlock"
Expand Down