Created larger click spots for secondary navbar. #1
Open
Kirk-Esterline wants to merge 1 commit intotomwinskell:mainfrom
Open
Created larger click spots for secondary navbar. #1Kirk-Esterline wants to merge 1 commit intotomwinskell:mainfrom
Kirk-Esterline wants to merge 1 commit intotomwinskell:mainfrom
Conversation
…ectorAll for navbarSecondaryDesktop to be the entire li within the containing div not limited to the 'a' only. This increased the clickable area resulting in a slightly better user experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the querySelectorAll for navbarSecondaryDesktop to be the entire
liwithin the containingdivnot limited to theaonly. This increased the clickable area resulting in a slightly better user experience.To ensure proper scoping only
liwithin#js__navbar-secondary--desktopwere selected. This results in only the three intendedlibeing affected by this change.My testing didn't result in any adverse effects to this change.