feat: improve semantic accessibility structure of dashboard page#7
Merged
feat: improve semantic accessibility structure of dashboard page#7
Conversation
Added semantic improvements for accessibility and updated focus styles for buttons and inputs.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did I change?
I improved the semantic accessibility structure of the page by adding a semantic header, a main landmark for the dashboard, a semantic heading for the dashboard title, explicit labels for form inputs, and semantic button elements for the add controls.
Why did I change it?
Lighthouse identified that the document did not have a main landmark. Manual inspection also showed that the dashboard title was not marked as a semantic heading, the input fields lacked explicit labels, and clickable add controls were implemented as generic div containers instead of semantic buttons.
Where is the old-vs-new code?
The main changes are in index.html and style.css. Before-vs-after snippets will be included in the report.
What screenshots are included?