Fix alchemist-phoenix for new phoenix structure (#306) #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `web' directory is removed with phx1.3 and placed under lib/<app-name>_web instead. Also change phoenix.routes -> phx.routes
Owner
|
@ovid-nis could you try to fix the tests? I really would like to get your PR ready. |
|
I would like to help get this fixed. I'm having trouble getting things set up locally so I can run the tests. Is there a good reference for setting up the alchemist.el package (or any package) for local development so I can assist? |
This was referenced Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The `web' directory is removed with phx1.3 and placed under
lib/_web instead.
Also change phoenix.routes -> phx.routes