Potential fix for code scanning alert no. 3: Prototype-polluting function#23
Open
tonyrobots wants to merge 1 commit intomainfrom
Open
Potential fix for code scanning alert no. 3: Prototype-polluting function#23tonyrobots wants to merge 1 commit intomainfrom
tonyrobots wants to merge 1 commit intomainfrom
Conversation
…tion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/tonyrobots/dcc-qol/security/code-scanning/3
The safest minimal fix is to block prototype-pollution keys (
"__proto__","constructor", and"prototype") early in the merge loop, before any use oforiginal[k], recursion, deletion, or assignment. This preserves existing behavior for normal keys while preventing writes/traversal into prototype chains.In
scripts/__mocks__/foundry.js, insideglobal.foundry.utils.mergeObject, update the loop that iteratesObject.entries(other):-=prefix normalization, add a guard:if (k === "__proto__" || k === "constructor" || k === "prototype") continue;This ensures dangerous keys are ignored in both top-level and recursive merges without changing other merge semantics.
No new imports or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.