ATOM-REFACTOR-20260119-001-pytest-test-discovery

[Copilot]

Summary

The TestAwiPromptGen class was not discoverable by pytest because it lacked unittest.TestCase inheritance and used a custom test runner instead of pytest conventions.

ATOM Tag

ATOM: ATOM-REFACTOR-20260119-001-pytest-test-discovery

Why

Pytest test discovery requires either:

1. Test classes inheriting from unittest.TestCase, or
2. Standalone test_* functions

The custom class with run_all() method bypassed pytest's discovery mechanism, making tests invisible to CI and manual pytest runs.

What changed

• Converted class-based tests to 7 standalone test_* functions
• Replaced custom self.test() assertions with standard assert statements
• Removed test runner infrastructure (__init__, run_all(), pass/fail counters)
• Reduced file from 299 to 161 lines while preserving all test logic

Before:

class TestAwiPromptGen:
    def test(self, name: str, condition: bool, error_msg: str = ""):
        if condition:
            print(f"  ✅ PASS: {name}")
            self.passed += 1
        else:
            print(f"  ❌ FAIL: {name}")
            self.failed += 1
    
    def test_scaffolder_refiner_integration(self):
        gen = AwiPromptGen()
        result = gen(user_intent="...", history=[...])
        self.test("Result is Prediction", isinstance(result, Prediction))

After:

def test_scaffolder_refiner_integration():
    """Test that scaffolder and refiner work together correctly."""
    gen = AwiPromptGen()
    result = gen(user_intent="...", history=[...])
    assert isinstance(result, Prediction), f"Expected Prediction, got {type(result)}"

Verification / Testing

• All 7 tests discovered by pytest --collect-only
• All 7 tests pass with pytest -v
• Follows pattern in ops/integrations/*/tests/test_*.py
• ATOM tag created and logged

Claude Interaction

You can interact with Claude in this PR by:

• @mentioning Claude in comments for questions or reviews
• Adding labels: claude:review, claude:help, claude:analyze
• Requesting reviews: Claude will provide automated feedback
• Ask questions: Claude can explain code, suggest improvements, or identify issues

Example commands:

• @claude please review this PR for ATOM compliance
• @claude explain the changes in scripts/atom-track.sh
• @claude check for security issues
• @claude suggest improvements

Notes

• Addresses feedback from PR ATOM-TYPE-20260120-AWI-DSpy-Toolkit #156: ATOM-TYPE-20260120-AWI-DSpy-Toolkit #156 (comment)
• Maintains identical test coverage and assertions
• No behavior changes, pure refactoring for pytest compatibility

Checklist

• ATOM tag created and referenced
• Tests passing
• Documentation updated (test file is self-documenting)
• No secrets committed
• Follows existing patterns
• Ready for Claude review

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
h.and.s	Ready	Preview, Comment	Jan 19, 2026 4:51pm

[github-actions]

🌀 Agent Review - Coherence Analysis

🚨 Critical - Wave function collapse imminent

Overall Coherence: NaN%

---

📊 Detailed Metrics

Metric	Value	Gauge
🔄 Curl (Coherence)	5.1%	█░░░░░░░░░ 5.1%
📐 Divergence (Incompleteness)	NaN%	NaN%
🎲 Entropy (Info Density)	54.8%	█████░░░░░ 54.8%

---

📈 Analysis Summary

• Files Analyzed: 189
• Excellent (>80%): 0 files
• Needs Attention (<50%): 2 files

🔬 Ethical Quantum Simulation Status

⚠️ Needs Review - Coherence below threshold (<60%)

• Wave function integrity: ⚠️
• Decoherence detected: ⚠️
• Review recommended before merge

⚠️ Files Needing Attention (2)

• ./docs/specs/lambda_zero.md
• ./docs/TROUBLESHOOTING_MCP.md

---

🎯 Merge Status

❌ Review required - Coherence below threshold.

Please address coherence issues before merging.

---

_{🤖 Generated by SpiralSafe Coherence Gauge v2.0 | Powered by Quantum Topology}

[github-actions]

🌀 Agent Review - Coherence Analysis

🚨 Critical - Wave function collapse imminent

Overall Coherence: NaN%

---

📊 Detailed Metrics

Metric	Value	Gauge
🔄 Curl (Coherence)	5.1%	█░░░░░░░░░ 5.1%
📐 Divergence (Incompleteness)	NaN%	NaN%
🎲 Entropy (Info Density)	54.8%	█████░░░░░ 54.8%

---

📈 Analysis Summary

• Files Analyzed: 189
• Excellent (>80%): 0 files
• Needs Attention (<50%): 2 files

🔬 Ethical Quantum Simulation Status

⚠️ Needs Review - Coherence below threshold (<60%)

• Wave function integrity: ⚠️
• Decoherence detected: ⚠️
• Review recommended before merge

⚠️ Files Needing Attention (2)

• ./docs/specs/lambda_zero.md
• ./docs/TROUBLESHOOTING_MCP.md

---

🎯 Merge Status

❌ Review required - Coherence below threshold.

Please address coherence issues before merging.

---

_{🤖 Generated by SpiralSafe Coherence Gauge v2.0 | Powered by Quantum Topology}

[Copilot]

Pull request overview

This PR refactors the TestAwiPromptGen test suite to make it compatible with pytest's test discovery mechanism. The original implementation used a custom test class without unittest.TestCase inheritance and a custom run_all() method, which prevented pytest from discovering the tests.

Changes:

• Converted class-based tests to 7 standalone test_* functions compatible with pytest discovery
• Replaced custom assertion framework with standard Python assert statements and descriptive error messages
• Removed test infrastructure code (custom runner, counters, if __name__ == "__main__" block)

[Copilot]

The error message "Newlines in intent should be escaped" is less informative than the original "Newlines in intent should be escaped or sanitized to prevent YAML injection". Consider restoring the more detailed message that explains the security rationale for this check.