Skip to content

Conversation

kjwcoo
Copy link
Contributor

@kjwcoo kjwcoo commented Jun 14, 2025

Sweep framework for QICK now supports data acquisition from acquire_decimated.

marcosfrenkel
marcosfrenkel previously approved these changes Jun 16, 2025
@marcosfrenkel marcosfrenkel dismissed their stale review June 16, 2025 20:36

I think I missed something

Copy link
Contributor

@marcosfrenkel marcosfrenkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 Things:

  • You have a big assumption here that there is only a single DecimatedVariable in the QICK program, this is not specified nor enforced in the code. I am scared people will try to try to have multiple of them in the same program and the data will get scrambled up.
  • Could we try having DecimatedVariable be a child class of ComplexQICKData and remove any mention of DecimatedVariable in in the ComplexQICKData section of that elif section (keep all the logic for each type of dataspec on their own section).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants