Refactor plyr::rbind.fill --> dplyr::bind_rows#1386
Open
MichaelChirico wants to merge 1 commit intotopepo:masterfrom
Open
Refactor plyr::rbind.fill --> dplyr::bind_rows#1386MichaelChirico wants to merge 1 commit intotopepo:masterfrom
MichaelChirico wants to merge 1 commit intotopepo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of the series towards dropping {plyr} dependency: #1382, #1383, #1385.
There are some differences between these two functions, most notable that
bind_rows()doesn't as happily coerce columns from non-character to character or non-list to list. I tried to document this a bit more extensively:https://gist.github.com/MichaelChirico/8df9b42e0e42d32828b34a641d33dc8c
Lines commented with
###fail on one or the other package.This PR passes the package's tests, so I am not sure they matter; I can write some more tests if you think it's appropriate.
It should also be highlighted that this switches {dplyr} from Suggests to Imports dependency.