Refactor ddply from ctrl$functions$summary-style calls#1404
Open
MichaelChirico wants to merge 1 commit intotopepo:masterfrom
Open
Refactor ddply from ctrl$functions$summary-style calls#1404MichaelChirico wants to merge 1 commit intotopepo:masterfrom
MichaelChirico wants to merge 1 commit intotopepo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are perhaps the hardest to manage because
ctrl$functions$summary, at least in the few cases I looked at, can ultimately come from a user-supplied list, therefore I am trying to retain maximum generality for back-compatibility. IINM all of the defaults are to usedefaultSummary(), which we could instead choose to implement in a more {dplyr}-friendly manner.This is the final {plyr}-related PR: once #1382 through here are merged, the {plyr} dependency can be removed.