Changed List to Pair, and also re-implemented type_of#3
Open
wongjiahau wants to merge 5 commits intomasterfrom
Open
Changed List to Pair, and also re-implemented type_of#3wongjiahau wants to merge 5 commits intomasterfrom
wongjiahau wants to merge 5 commits intomasterfrom
Conversation
hch12907
reviewed
Feb 14, 2020
src/node.rs
Outdated
| pub fn cdr(node: Node) -> Result<Node, &'static str> { | ||
| match node { | ||
| Node::Pair(_, b) => Result::Ok(*b), | ||
| _ => Result::Err("Cannot apply cdr to Pair") |
There was a problem hiding this comment.
I think it's better to use a dedicated Error enum instead of a string for Result::Err... but I digress
There was a problem hiding this comment.
However, for this case Option<T> is better as your return type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.