Skip to content

Conversation

@Deveroonie
Copy link
Contributor

@Deveroonie Deveroonie commented Dec 6, 2025

Does what it says on the tin really. Makes it so that the "last updated" reflects the user's system date settings, instead of defaulting to MM/DD/YYYY

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Updated date display in settings to respect your system's locale preferences instead of using a fixed format.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025

Walkthrough

A locale-specific date formatting configuration in the settings state has been modified to use the default locale instead of explicitly specifying en-US in the toLocaleDateString() method call.

Changes

Cohort / File(s) Summary
Date formatting localization
src/scripts/views/settings/state.ts
Removed explicit 'en-US' locale argument from toLocaleDateString() to use the browser's default locale for displaying the lastModified date

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A locale unfixed, now free to roam,
Default dates find their way back home,
From en-US chains, the timestamps spring,
To speak in tongues—a simpler thing!

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating date formatting in settings to use the user's locale instead of a fixed en-US format.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a2a050 and f8bc7d5.

📒 Files selected for processing (1)
  • src/scripts/views/settings/state.ts (1 hunks)
🔇 Additional comments (1)
src/scripts/views/settings/state.ts (1)

21-21: Locale-aware date formatting change matches the PR objective

Using lastModified.toLocaleDateString() without an explicit locale now relies on the browser/host default locale, so the "last updated" date will follow the user’s language/region settings instead of always being en-US. This aligns with the stated goal and doesn’t introduce any new correctness issues.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2025

Copy link
Contributor

@shadowwwind shadowwwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thank you!

LGTM

@ptgms ptgms merged commit 19ffd5d into tosdr:master Dec 8, 2025
6 checks passed
@shadowwwind
Copy link
Contributor

btw very annoying that FF dev edition seemingly does not support changing the browser language when started through web-ext ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants