refactor: remove TCA dependency and migrate to @Observable MVVM#1
Open
refactor: remove TCA dependency and migrate to @Observable MVVM#1
Conversation
- Replace all Reducers (Home, Result, PastResults, Counter, Initial, Round) with @observable ViewModels using Swift Concurrency - Fix iPhoneConnecter nested delegate function bug and AsyncStream overwrite bug using AsyncStream.makeStream() pattern - Fix WatchConnecter typo: isGmaeStarted → isGameStarted - Fix RoundView Finish button that was incorrectly commented out - Convert RoundModel from NSObject class to struct with Equatable conformance - Remove TCA + 12 transitive dependencies from Package.resolved and project.pbxproj - Update CommonModel minimum watchOS target from v6 to v10 26 files changed, +273/-721 lines
tosh7
force-pushed
the
feature/remove-tca
branch
from
6f08745 to
daaeed1
Compare
tosh7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Observable+ MVVM architecture@ObservableViewModelsChanges
Bug Fixes
AsyncStreamcontinuation overwrite bug usingAsyncStream.makeStream()isGmaeStarted→isGameStartedArchitecture Migration
@Presents+.ifLet→ SwiftUI nativenavigationDestination(isPresented:)Effect.run→ Swift Concurrency (async/await,AsyncStream)Model Improvements
class: NSObjecttostruct: EquatableDependency Removal
project.pbxprojPackage.resolved(2 files)Stats
Test plan