Skip to content

Conversation

@socksy
Copy link
Contributor

@socksy socksy commented Jan 5, 2026

When trying to debug the broken merge parameters thing in the schedule, I noticed we have a lot of log spam for printing the env vars — a new line per environment variable. Given how many secrets we have in tower, this ends up being a lot...

Screenshot 2026-01-05 at 13 51 06 (but much more than that)

Since we add each env var to res anyway, I think it's neater to just print out the keys of res.

Before:

2026-01-05T15:16:12.409817Z DEBUG  adding key TOWER_INFERENCE_ROUTER

  2026-01-05T15:16:12.409826Z DEBUG  adding key AWS_REGION

  2026-01-05T15:16:12.409830Z DEBUG  adding key DUCKDB_DATASET_NAME

  2026-01-05T15:16:12.409832Z DEBUG  adding key SENTRY_DSN

  2026-01-05T15:16:12.409837Z DEBUG  adding key SLACK_WEBHOOK_URL

  2026-01-05T15:16:12.409841Z DEBUG  adding key PYICEBERG_CATALOG__DEFAULT__CREDENTIAL

  2026-01-05T15:16:12.409844Z DEBUG  adding key GITHUB_TOKEN

  2026-01-05T15:16:12.409846Z DEBUG  adding key my_secret

  2026-01-05T15:16:12.409851Z DEBUG  adding key DBT_SEED_ARCHIVE_URI

  2026-01-05T15:16:12.409855Z DEBUG  adding key DISCORD_BOT_TOKEN

  2026-01-05T15:16:12.409858Z DEBUG  adding key POSTGRES_URI

  2026-01-05T15:16:12.409861Z DEBUG  adding key DB_ANALYST_SLACK_BOT_TOKEN

  2026-01-05T15:16:12.409870Z DEBUG  adding key some-secret

  2026-01-05T15:16:12.409872Z DEBUG  adding key DBT_PROFILE_YAML

  2026-01-05T15:16:12.409876Z DEBUG  adding key TOWER_INFERENCE_ROUTER_API_KEY

  2026-01-05T15:16:12.409882Z DEBUG  adding key DUCKDB_FILE

  2026-01-05T15:16:12.409885Z DEBUG  adding key DUCKDB_PIPELINE_NAME

  2026-01-05T15:16:12.409889Z DEBUG  adding key foe

  2026-01-05T15:16:12.409892Z DEBUG  adding key friend

  2026-01-05T15:16:12.409895Z DEBUG  adding key PYICEBERG_CATALOG__DEFAULT__SCOPE

  2026-01-05T15:16:12.409899Z DEBUG  adding key TOWER_JWT

  2026-01-05T15:16:12.409902Z DEBUG  adding key PYICEBERG_CATALOG__DEFAULT__WAREHOUSE

  2026-01-05T15:16:12.409905Z DEBUG  adding key TOWER_URL

  2026-01-05T15:16:12.409907Z DEBUG  adding key PYICEBERG_CATALOG__DEFAULT__URI

  2026-01-05T15:16:12.409910Z DEBUG  adding key PYICEBERG_CATALOG__DEFAULT__CREDENTIAL

after

  2026-01-05T15:16:12.409921Z DEBUG  added keys POSTGRES_URI, PYICEBERG_CATALOG__DEFAULT__SCOPE, DBT_SEED_ARCHIVE_URI, GITHUB_TOKEN, foe, TOWER_URL, AWS_REGION, PYICEBERG_CATALOG__DEFAULT__CREDENTIAL, SENTRY_DSN, SLACK_WEBHOOK_URL, DUCKDB_DATASET_NAME, some-secret, TOWER_INFERENCE_ROUTER_API_KEY, friend, DISCORD_BOT_TOKEN, DUCKDB_PIPELINE_NAME, TOWER_JWT, my_secret, TOWER_INFERENCE_ROUTER, DBT_PROFILE_YAML, PYICEBERG_CATALOG__DEFAULT__WAREHOUSE, PYICEBERG_CATALOG__DEFAULT__URI, DUCKDB_FILE, DB_ANALYST_SLACK_BOT_TOKEN

@socksy socksy merged commit cafc4f7 into develop Jan 6, 2026
5 checks passed
@socksy socksy deleted the ben/reduce-env-var-debug-spam branch January 6, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants