Fix bulk-load.js loading items as "null" #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, it's me again, the same guy who made stupid issues and bothered you on facebook quite a while ago. After 4 years, I have returned with much more coding (and life) knowledge, ready to get this project into a more usable state
Running any Tower Storm's node app that uses the
bulk-load.jsfile (ex.botmanager/index.js) causes it to crash, due tofile.path.match(/\/([^\/.]+)\./)returning null.This pull request fixes that by replacing the
file.path.matchfunction withfile.replace, and changing regex to target the file extension.Regex should only target the characters after the last dot, to prevent files like
foo.bar.jsbeing read asfoo.