Skip to content

Conversation

@fonsp
Copy link
Contributor

@fonsp fonsp commented Sep 2, 2020

No description provided.

@fonsp
Copy link
Contributor Author

fonsp commented Sep 2, 2020

This is two changes in one:

  1. The default value for get(ENV, "COMSPEC", "cmd") was not used
  2. Using cmd.exe instead of cmd means that it will work from WSL (which I will submit a 2nd PR for)

EDIT: 1. is also done by #10

@tpapp
Copy link
Owner

tpapp commented Sep 2, 2020

Thanks!

@tpapp tpapp merged commit 1017db3 into tpapp:master Sep 2, 2020
@fonsp fonsp deleted the patch-1 branch September 2, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants