implement element access API, extensions for Accessors #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI error is EnzymeAD/Enzyme.jl#2653, unrelated. |
devmotion
reviewed
Oct 10, 2025
Comment on lines
+7
to
+8
| const LENSES = Union{IndexLens,PropertyLens} | ||
|
|
There was a problem hiding this comment.
LENSES is not used below:
Suggested change
| const LENSES = Union{IndexLens,PropertyLens} |
| (; transformations) = transformation | ||
| repr1 = (transformations isa NamedTuple ? "NamedTuple" : "Tuple" ) * " of transformations" | ||
| inner = _inner(transformation) | ||
| repr1 = (inner isa NamedTuple ? "NamedTuple" : "Tuple" ) * " of transformations" |
There was a problem hiding this comment.
Could be simplified to something like
Suggested change
| repr1 = (inner isa NamedTuple ? "NamedTuple" : "Tuple" ) * " of transformations" | |
| repr1 = string(nameof(typeof(inner)), " of transformations") |
| Helper function for accessing the `inner` field, as we define `getproperty` which masks | ||
| this. Internal. | ||
| """ | ||
| @inline _inner(t) = getfield(t, :inner) |
There was a problem hiding this comment.
Are the @inline annotations actually needed?
|
|
||
| const LENSES = Union{IndexLens,PropertyLens} | ||
|
|
||
| set(t::TransformTuple, ::typeof(_inner), inner) = TransformTuple(inner) |
There was a problem hiding this comment.
Should/could we here and in the following definitions restrict the third argument to suitable types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.