Conversation
apricot13
requested changes
Sep 16, 2025
...iews/bops_api/v2/shared/postsubmissionApplication/comments/_comment_specialist.json.jbuilder
Outdated
Show resolved
Hide resolved
...iews/bops_api/v2/shared/postsubmissionApplication/comments/_comment_specialist.json.jbuilder
Outdated
Show resolved
Hide resolved
...iews/bops_api/v2/shared/postsubmissionApplication/comments/_comment_specialist.json.jbuilder
Outdated
Show resolved
Hide resolved
b2b0d18 to
8e27fe0
Compare
Reduce diff Adjust jbuilder and schema Add files Files Files restructure response data to be in ApiResponse format, adjustments to jbuilder and schema/swagger doc/tests replace jbuilder logic with specialist presenter pattern rebase fixes
8e27fe0 to
adb5e91
Compare
apricot13
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR updates the specialist comment endpoint to use the new schema.
The response now returns a pagination, and a data object. Within the data object, the specialist summary, and also an array of specialists who have responded and have had their comments redacted, and within each specialist is their details, related constraint information (if applicable) and an array of all their comments which includes details such as their sentiment, any files and redacted comments.
Example payload:
Story Link
DSNPI-1320
Decisions
validated_atdate in the current comment flow. Additionally, there is aredacted_atproperty but it doesn't seem to get set when a comment is redacted.Known issues [OPTIONAL]
We have limited this ticket to not handle all of the constraint data we expect for now.