Skip to content

Support passing -Width and -Height also when redirecting in/out #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timfel wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −6
Open

Support passing -Width and -Height also when redirecting in/out #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions src/Sixel/Terminal/Validate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,18 @@ internal sealed class ValidateTerminalWidth : ValidateArgumentsAttribute {
/// <exception cref="ValidationMetadataException"></exception>
protected override void Validate(object arguments, EngineIntrinsics engineIntrinsics) {
int requestedWidth = (int)arguments;
int hostWidth = Console.WindowWidth;
if (requestedWidth > hostWidth) {
throw new ValidationMetadataException($"{requestedWidth} width is greater than terminal width ({hostWidth}).");
if (Console.IsOutputRedirected || Console.IsInputRedirected) {
return;
}

try {
int hostWidth = Console.WindowWidth;
if (requestedWidth > hostWidth) {
throw new ValidationMetadataException($"{requestedWidth} width is greater than terminal width ({hostWidth}).");
}
}
catch {
// When no interactive console is attached, skip terminal-bound validation.
}
}
}
Expand All @@ -33,9 +42,18 @@ internal sealed class ValidateTerminalHeight : ValidateArgumentsAttribute {
/// <exception cref="ValidationMetadataException"></exception>
protected override void Validate(object arguments, EngineIntrinsics engineIntrinsics) {
int requestedHeight = (int)arguments;
int hostHeight = Console.WindowHeight;
if (requestedHeight > hostHeight) {
throw new ValidationMetadataException($"{requestedHeight} height is greater than terminal height ({hostHeight}).");
if (Console.IsOutputRedirected || Console.IsInputRedirected) {
return;
}

try {
int hostHeight = Console.WindowHeight;
if (requestedHeight > hostHeight) {
throw new ValidationMetadataException($"{requestedHeight} height is greater than terminal height ({hostHeight}).");
}
}
catch {
// When no interactive console is attached, skip terminal-bound validation.
}
}
}