Send webhooks in a new thread.#1
Open
bsrecker wants to merge 1 commit intotradingstrategy-ai:masterfrom
Open
Conversation
|
Hello @bsrecker, I was going through the Pull Request and noticed the use of threads ( Could you please explain the reasons that led to this choice rather than an approach based on coroutines? This could help in better understanding the context of the modification. Thanks in advance for providing clarification. |
Contributor
|
Good morning all. I just noticed this pull request one year later. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation was problematic because webhook posts were not being handled in a separate thread. This PR attempts to resolve that by triggering a new thread for each post.
Additionally, the timeout duration was increased to 10 to accommodate any network issues.