-
Notifications
You must be signed in to change notification settings - Fork 159
scale minikube resources based on system #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ret2libc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about this for now. The request resources depends heavily on the number of pods you want to spawn, so maybe on lower systems you also want to reduce the number of build-bot, etc and maybe reduce the resource constraints of some of those pods.
|
@claude use docker system info data and get the cpus/memory from there |
|
Claude finished @BradSwain's task —— View job Task List
Changes Made✅ Replaced OS-specific resource detection with SummaryThe script now uses Key improvements:
|
…commands This ensures minikube gets accurate Docker-available resources rather than system-wide resources, which is especially important on macOS with Docker Desktop/Colima where Docker resources may be constrained. Co-authored-by: Brad Swain <BradSwain@users.noreply.github.com>
|
@claude address the review |
|
Claude finished @ret2libc's task —— View job Task List
Changes Made✅ Updated minimum CPU requirement from 2 to 5 cores (deployment/crs-architecture.sh:116) SummarySuccessfully addressed both review comments:
The changes ensure that minikube deployments will only proceed on systems that meet the actual resource requirements for running Buttercup effectively. Commit: |
- Increase minimum CPU requirement from 2 to 5 cores - Decrease minimum memory requirement from 16GB to 10GB for k8s cluster - Add proper variable quoting to fix shellcheck warnings Co-authored-by: Riccardo Schirone <ret2libc@users.noreply.github.com>
| MINIKUBE_CPUS=$((AVAILABLE_CPUS > 7 ? 8 : AVAILABLE_CPUS > 4 ? AVAILABLE_CPUS - 1 : AVAILABLE_CPUS)) | ||
| MINIKUBE_MEMORY_MB=$((AVAILABLE_MEMORY_MB * 75 / 100)) | ||
|
|
||
| # Check if system meets minimum requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README should document the minimum requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also go in the #214 PR
|
Got pulled to some other work, but I plan to make the resources configurable during setup instead of during deployment. I made env vars to configure minikube resources, pod count, and individual pod resource, and moved the "detect resources" logic to a script that runs during local setup |
|
Closed in favor of listing the minimum required resources in #214 |
* Add retrieving types from treesitter * Update preprocessor types. Update fuzz-tooling directory layout
Related #169
This changes the minikube deployment to use more resources, if available.
It also allows the deployment to run on systems with less than the previously hardcoded resources (8cpus, 32g mem).
It warns if resources are below some threshold, and errors if below a minimum threshold.
I took a best guess at what good values would be, but they can be changed/updated.