Skip to content

Expand dangerous imports blocklist for better coverage #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dguido wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expand dangerous imports blocklist for better coverage #215

dguido wants to merge 1 commit into from

Conversation

@dguido
Copy link
Member

@dguido dguido commented Jan 23, 2026

Summary

  • Expands UNSAFE_IMPORTS in fickle.py from ~20 to ~60+ modules
  • Adds network modules (requests, aiohttp, httplib, etc.)
  • Adds FFI modules (ctypes, _ctypes)
  • Adds profiling/debugging modules (cProfile, profile, pdb, timeit, trace)
  • Adds pickle recursion modules (pickle, dill, cloudpickle, joblib)
  • Adds filesystem modules (shutil, tempfile, distutils)
  • Adds import manipulation modules (importlib, pkgutil, zipimport)
  • Adds torch dangerous modules (torch.hub, torch._dynamo, etc.)

Test plan

  • All existing tests pass
  • Linters pass
  • Manual verification with test pickle files

🤖 Generated with Claude Code

@dguido @claude
Expand dangerous imports blocklist for better coverage
a6dae26 
Add ~40 additional modules to UNSAFE_IMPORTS including:
- Network modules (requests, aiohttp, httplib, etc.)
- FFI modules (ctypes, _ctypes)
- Profiling/debugging (cProfile, profile, pdb, timeit, trace)
- Pickle recursion (pickle, dill, cloudpickle, joblib)
- Filesystem (shutil, tempfile, distutils)
- Import manipulation (importlib, pkgutil, zipimport)
- Torch dangerous (torch.hub, torch._dynamo, torch._inductor, torch.jit)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@dguido dguido requested a review from ESultanik as a code owner January 23, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ESultanik ESultanik Awaiting requested review from ESultanik ESultanik is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dguido