fix missing role info when creating user#12
Open
thomasDOTwtf wants to merge 1 commit intotrajche:masterfrom
Open
fix missing role info when creating user#12thomasDOTwtf wants to merge 1 commit intotrajche:masterfrom
thomasDOTwtf wants to merge 1 commit intotrajche:masterfrom
Conversation
|
We had the same issues, this change fixed it |
Author
|
@LizardM4 might you be able to review and merge? |
Contributor
|
@thomasDOTwtf sure! @BlueTeck It seems sensible that a new user assumes the app user role by default, but I think we should use the |
|
In my private fork, I've changed the constructor instead and didn't pass an default role. https://github.com/trajche/SamlAuth/blob/master/User/SamlUserProvider.php#L39
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding a default user role to newly created objects.
This is an alternate approach to issue #11