Skip to content

U/swinbank/fix test #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jdswinbank wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

U/swinbank/fix test #570

jdswinbank wants to merge 12 commits into from

Conversation

@jdswinbank
Copy link
Member

@jdswinbank jdswinbank commented Oct 12, 2019

No description provided.

@jdswinbank
Add capability to skip all tests requiring the DB.
609d2c2 
This means that if I

- Don't have any database set up; and
- ``export TKP_DBDISABLED=1``

I can get a clean run of the test suite:

  Ran 376 tests in 543.274s
  OK (SKIP=102)

(Previously, I was seeing many database connection errors.)
@jdswinbank
Tweak tests with issues.
55324ae
@jdswinbank
Remove test_accessors.
4d74476
@jdswinbank
Copy link
Member Author

jdswinbank commented Oct 12, 2019

Well, there's a smoking gun — the error is coming from TestEphemeris because casacore can't find its TAI_UTC data table:

======================================================================
1276ERROR: test_invalid_ephemeris (test_brightsource.TestEphemeris)
1277----------------------------------------------------------------------
1278Traceback (most recent call last):
1279  File "/home/travis/build/transientskp/tkp/tests/test_quality/test_brightsource.py", line 21, in test_invalid_ephemeris
1280    self.assertFalse(tkp.quality.brightsource.check_for_valid_ephemeris(dm))
1281  File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/tkp/quality/brightsource.py", line 31, in check_for_valid_ephemeris
1282    measures.direction("SUN"), measures.direction("SUN")
1283  File "/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/casacore/measures/__init__.py", line 962, in separation
1284    return _measures.separation(self, m0, m1)
1285RuntimeError: 2019-10-12 23:31:16	SEVERE	MeasTable::dUTC(Double) (file /build/casacore-3.1.1/measures/Measures/MeasTable.cc, line 4281)	Cannot read leap second table TAI_UTC

Out of time to look at this further for now. @gijzelaerr , I think (??) this data should be provided by the casacore-data package — any idea why it's not being found?

@gijzelaerr
Copy link
Collaborator

gijzelaerr commented Oct 13, 2019

maybe it is outdated?

@gijzelaerr
Copy link
Collaborator

gijzelaerr commented Oct 13, 2019

ah yes, this uses my new binary wheel of python-casacore, which isn't configured to look at the right spot. a .casacorerc (i think) file with the path to the casacore-data content needs to be created.

@gijzelaerr
Copy link
Collaborator

gijzelaerr commented Oct 13, 2019

casacore/python-casacore#181

@tammojan
Copy link

tammojan commented Jan 14, 2020

a .casacorerc (i think) file with the path to the casacore-data content needs to be created.

Almost right: it should be ~/.casarc. See description in casacore/python-casacore#181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdswinbank @gijzelaerr @tammojan