Open
Conversation
travisdesell
requested changes
Jun 19, 2025
rnn/rnn.cxx
Outdated
| } else if (this->loss == "mae") { | ||
| mse = calculate_error_mae(outputs); | ||
| backward_pass(mse * (1.0 / outputs[0].size()) * 2.0, using_dropout, training, dropout_probability); | ||
| } else { |
Owner
There was a problem hiding this comment.
This should be it's own case (else if loss == "stock"), then there should be a final else case which prints an error if a user didn't give one of the available loss options.
rnn/mse.cxx
Outdated
| } | ||
| } | ||
|
|
||
| void get_stock_loss (const vector<double>& output_values, const vector<double>& expected, double& loss_sum, vector<double>& deltas, |
Owner
There was a problem hiding this comment.
these should go into a stock_loss.cxx/hxx file.
| mses[i] = rnn->calculate_error_mae(outputs); | ||
| } else if (loss == "stock") { | ||
| mses[i] = rnn->calculate_error_stock_loss(inputs, outputs); | ||
| } |
Owner
There was a problem hiding this comment.
add an else case here with a helpful error message if an inappropriate loss is given (and include in the error message the available options).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added functionality for the StockLoss I function.
What type is this change?
Checklist before requesting a review
How Has This Been Tested?