Return comma separated list of LB IPs not just first #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 156de9b)
FinalDoom
commented
Dec 3, 2024
| $dnsmasqConfig = PfSenseConfigBlock::getRootConfigBlock($this->getController()->getRegistryItem('pfSenseClient'), 'dnsmasq'); | ||
| if (!isset($dnsmasqConfig->data) || !is_array($dnsmasqConfig->data)) { | ||
| $dnsmasqConfig->data = []; | ||
| } |
There was a problem hiding this comment.
There was a bug here if the hosts config is empty, it returns an empty string; so fixed that here and on unbound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #27
Demoed changes on https://onlinephp.io/c/ae9bb, and building locally. As mentioned, open to making this a setting, but I think all pfSense versions except those with the bug linked in #27 should accept a comma-separated list.
Slightly messy with implode/explode, but I didn't want to change the struct being used too much.