don't convert clabel into positive integers#53
Open
schoffelen wants to merge 1 commit intotreder:masterfrom
Open
don't convert clabel into positive integers#53schoffelen wants to merge 1 commit intotreder:masterfrom
schoffelen wants to merge 1 commit intotreder:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @treder Matthias, please feel free to ignore, but I was wondering about the fact that some of the preproc functions 'silently' convert a clabel vector into positive integers. In case of regression models this might be undesired I think. This PR addresses this.
PS: I noticed that there's now also a mv_preprocess_mmn function, which is great! But: shouldn't this be called mv_preprocess_mnn, rather than mmn?