[DEV] use pyhgtmap instead of phyghtmap for generating contour lines#234
Draft
[DEV] use pyhgtmap instead of phyghtmap for generating contour lines#234
pyhgtmap instead of phyghtmap for generating contour lines#234Conversation
Contributor
|
I think we can just use pyhgtmap with "jobs=1", then no forking is attempted, and it should work on windows as well. And then rather use asyncio to launch several instances of pyhgtmap. I'll do some testing on linux first and then on windows. |
dad7184 to
20db6d8
Compare
- to be installed when wahoomc is installed via pip - to have a environment to test pyhgtmap
- todo: remove documentation about installing phyghtmap
20db6d8 to
396c437
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR…
pyhgtmapphyghtmapneeded anymoreConsiderations and implementations
Till now, there is no support for Windows, see agrenott/pyhgtmap#7
ToDO
adjust documentation
fix version of
pyhgtmapand think of other publish-related stuff for this PRHow to test
-conphyghtmapPull Request Checklist