Skip to content

V1.42.5 trex patched #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
princesingh wants to merge 3 commits into
base: v1.42.3-trex-patched
Choose a base branch
from
Open

V1.42.5 trex patched #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
603d2dc
Adding Credit Card Validation Scription
princesingh Mar 29, 2024
a598a6b
Card Brand Validation
princesingh Mar 29, 2024
4e93ae2
Removing Deprication Message
princesingh Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/active_merchant/billing/credit_card.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,12 @@ class CreditCard
attr_accessor :track_data

def type
self.class.deprecated "CreditCard#type is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand instead."
# self.class.deprecated "CreditCard#type is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand instead."
brand
end

def type=(value)
self.class.deprecated "CreditCard#type is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand instead."
# self.class.deprecated "CreditCard#type is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand instead."
self.brand = value
end

Expand Down Expand Up @@ -240,7 +240,8 @@ def validate_card_number #:nodoc:

def validate_card_brand #:nodoc:
errors.add :brand, "is required" if brand.blank? && number.present?
errors.add :brand, "is invalid" unless brand.blank? || CreditCard.card_companies.keys.include?(brand)
# error.add bra
errors.add :brand, "is invalid" unless brand.blank? || CreditCard.card_companies.include?(brand)
end

alias_method :validate_card_type, :validate_card_brand
Expand Down
Loading