Skip to content

Comments

Add Close() method to logger#18

Merged
treyburn merged 4 commits intomainfrom
treyburn/logger-close
Nov 1, 2025
Merged

Add Close() method to logger#18
treyburn merged 4 commits intomainfrom
treyburn/logger-close

Conversation

@treyburn
Copy link
Owner

  • Add a Close() method to the Logger interface
  • Basic implementation for both File and Postgres loggers
  • Added synctest for File logger to ensure we don't leak any goroutines.

@treyburn treyburn self-assigned this Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.07%. Comparing base (f6428ab) to head (bea1490).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/logger/postgres.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   32.68%   33.07%   +0.39%     
==========================================
  Files           5        5              
  Lines         257      263       +6     
==========================================
+ Hits           84       87       +3     
- Misses        170      173       +3     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@treyburn treyburn merged commit 832ca60 into main Nov 1, 2025
5 checks passed
@treyburn treyburn deleted the treyburn/logger-close branch November 1, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant