Open
Conversation
Owner
|
Hey there— I'm so sorry I haven't replied to this... I truly don't understand how I didn't see it, as I've replied to other GitHub issues in the meantime. But this is the first time I'm seeing this patch. You've likely moved on now, but in case you haven't, I'll be happy to merge given a couple things:
|
Author
|
Hi treyharris, Thanks for reply. According to your suggestion...
Regards, |
|
This looks great, and is probably a much better version of a patch I have applied locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
"/\s*/" based word wrapping is not working with Japanese context.
Because usually Japanese string doesn't contain any white spaces in
context.
I added line folding code (based on Text::LineFold). It works fine
with English and Japanese context.
Regards,
AYANOKOUZI, Ryuunosuke
AYANOKOUZI, Ryuunosuke i38w7i3@yahoo.co.jp