feat: dynamically resolve latest upstream#6
Merged
treyturner merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
5d628f0 to
360033c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRAWL_TAGversion from all CI workflows and theDockerfile, replacing it with dynamic resolution of the latest upstream release at build timeCRAWL_TAGis omitted, the builder stage queries the GitHub Releases API (/repos/crawl/crawl/releases/latest) to resolve the tag, writes it to/tmp/crawl-tag, and copies it into the runtime image at/app/crawl-tagbuildaction now runs Docker Buildx before tag computation, then reads the resolved version from the built image to drive tagging — eliminating the chicken-and-egg dependency between tag resolution and the build stepcache-scope/cache-fallback-scopeinputs; cache scope is now derived directly fromupstream-ref(or'latest'when omitted)<version>-dev-<run_id>.<attempt>) to simplify the tag surfaceCRAWL_TAGas a runtimeENVvariable; the entrypoint now reads it from/app/crawl-tagat startupvprefix from all version tags and workflow inputs (e.g.0.34.1instead ofv0.34.1) for consistencyTest plan
build-and-test-prworkflow completes without an explicitupstream-ref, confirming the latest DCSS release is resolved automaticallyCRAWL_TAGby reading/app/crawl-tagfrom the built imagebuild-and-publishwithout anupstream-refinput and verify the published image is tagged with the resolved version (e.g.0.34.1-dev)build-and-publishwith an explicitupstream-ref(e.g.0.34.0) and verify that version is used instead of latestpromote-tagwith a bare version string (e.g.0.34.1) and confirm validation accepts it and rejects the oldv-prefixed format--build-arg CRAWL_TAGand verify the image resolves and bakes in the latest tag