Skip to content

Build arm docker image on arm runner#8

Open
miline wants to merge 2 commits intomainfrom
feature/miline/build_arm_on_arm
Open

Build arm docker image on arm runner#8
miline wants to merge 2 commits intomainfrom
feature/miline/build_arm_on_arm

Conversation

@miline
Copy link
Member

@miline miline commented Mar 12, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Docker image build workflow to run ARM builds on an ARM GitHub Actions runner, aiming to avoid emulation for ARM targets while continuing to publish per-architecture images to GHCR.

Changes:

  • Adds an OS dimension to the build matrix (ubuntu-latest and an ARM runner) and selects the runner via runs-on: ${{ matrix.os }}.
  • Excludes incompatible OS/arch combinations so AMD64 builds run on x86_64 and ARM builds run on ARM.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 30 to 33
arch:
- amd64
- armhf
- aarch64
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matrix arch values are later interpolated into platforms: linux/${{ matrix.arch }}. Docker/Buildx platform arch names are amd64, arm64, and arm (optionally with a variant like arm/v7), so aarch64 (and likely armhf) will produce invalid platform strings (e.g., linux/aarch64) and can cause the build step to fail. Consider separating the image tag suffix from the Buildx platform value (e.g., keep aarch64/armhf for tagging if desired, but add a matrix field for the actual platform such as linux/arm64 and linux/arm/v7).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants