Remove EM_RISCV workaround #1367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
previously requested changes
Dec 1, 2025
Member
squell
left a comment
squell
left a comment
There was a problem hiding this comment.
Thanks for picking up this issue!
Note: 0.2.176 claims to have added EM_RISCV, so I'd prefer that to be the version in this PR instead of 0.2.177. The aim of our Cargo.toml is to really to have the minimal versions that we can build on to give downstream packagers much-needed flexibility.
For that reason, I'd also prefer to not update glob in this PR.
Note: Debian unstable is currently on 0.2.175, so even with the above changes we'll have to wait before merging this until they caught up with 0.2.176, or we're going to cause unneeded hassle.
joriskleiber
force-pushed
the
em_riscv-workaround
branch
from
d93c5fb to
c4c7ca5
Compare
Member
|
(Note for future self/future reviewer; this change is A-OK, just need to wait for merging until https://packages.debian.org/source/sid/rust-libc shows >= 0.2.176.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade libc to 0.2.176 and fixes #1236.