Check if stdio tty pgrp matches for exec_bg #1380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way redirecting stdio to another tty won't be treated as if stdio isn't redirected at all. This matches newer ogsudo versions.
bjorn3
commented
Dec 9, 2025
| // we are not in the foreground process group. | ||
|
|
||
| catching_sigttou(|| self.tty.tcsetpgrp(pgrp)) | ||
| catching_sigttou(|| self.tcsetpgrp(pgrp)) |
Collaborator
Author
There was a problem hiding this comment.
UserTerm implements AsFd to forward to self.tty. SafeTty is implemented for UserTerm, but not for the File stored in the tty field.
Collaborator
Author
|
Pushed a commit to port sudo-project/sudo@78b7121 too. |
exec_bg is already set and the only two other effects it has are calling disable_input() and changing a debug log message. The former is not necessary to do when stdout is a pipe to fix the missing keystroke issue while the latter now matches ogsudo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way redirecting stdio to another tty won't be treated as if stdio
isn't redirected at all.
This matches newer ogsudo versions.
Also introduced a
SafeTtytrait to ensure a bunch of methods that invoke ioctls only get called on known real ttys.Fixes #1377