Pull request1 #15
Open
Pull request1 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completely removes the PID logic, leaving only bang-bang control. This saves quite a bit of code space. Enough that I can add debugging even on a atmega168. Quite handy! And some people (nophead) don't need PID control.
This code will now compile correctly wether or not the MIN pins are defined.
Contributor
Author
|
Defining "bang-bang" will allow debugging to be built for a 168 chip. |
Contributor
Author
|
This was closed? Did I do that by mistake or did somebody mean to close this pull request? |
Owner
|
hi, is this still relevant to the current codebase? Without my motors set up I can't tell |
Contributor
Author
|
I don't know. With my laptop broken I can't tell :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's written in the commit comment, but basically I noticed that if I ran two moves:
G1X10
G1X10
I could hear the steppers hesitate between the moves. This change removes that hesitation, at the price of a possibly much longer-running timer interrupt.
This is because next_move is now tail-recursive when there are zero step moves queued.
Also it's not yet perfect, see commit notes for my reflections on the timer status across moves.