Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
This PR adds support for Swift 3, see #7
The project and test suit were also updated.
Please note that the syntax changes slightly, as reflected in the README. If you want to keep the old syntax we can change the lib to use the option first parameter label.
I would suggest a full version bump for this release (so, 2.0.0), to help late adopters.
As for CocoaPods, I suggest using version 1.1.0rc2. You'll find a new file in the repo, called
.swift-versionthat specifies the 3.0 compatibility, and will be used by CP during the trunk push.Let me know what you think.